Repository navigation
ci: unblock the test job (clippy 1.99 lint, rustls advisories) - #73
Merged
Merged
Conversation
Clippy 1.99 flags tonic's generated client methods, which put #[must_use] on a return type that is already #[must_use]. It is generated code, allowed next to the existing result_large_err allow. This was failing the test job on every PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JMTyE9inRv7Knv6jkmgDZs
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 35 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…sories cargo audit fails the test job on RUSTSEC-2026-0346/0347/0348/0349 (rustls) and RUSTSEC-2026-0382 (rustls-webpki). Both fixes are semver-compatible, so this is a lockfile-only update. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JMTyE9inRv7Knv6jkmgDZs
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's
testjob fails on current stable for two reasons that have nothing to do with recent changes:scylla.engine.v1.rs(double_must_use). This adds that lint to the existing allow on thepbmodule, next toresult_large_err.cargo auditfails on five new RustSec advisories inrustls0.23.45 (RUSTSEC-2026-0346/0347/0348/0349) andrustls-webpki0.103.15 (RUSTSEC-2026-0382). The fix is a lockfile-only update to 0.23.46 and 0.103.16.Separately,
http_gateway_token_gates_accessfailed once and passed on rerun.free_port()releases the port before the server binds it, so a parallel test's ungated server can take the port. That is a flaky test, not an auth bug, and this PR does not change it.This unblocks #72 and any other PR.
Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/
🤖 Generated with Claude Code
https://claude.ai/code/session_01JMTyE9inRv7Knv6jkmgDZs