Skip to content

ci: unblock the test job (clippy 1.99 lint, rustls advisories) - #73

Merged
CryptoJones merged 2 commits into
mainfrom
fix/clippy-double-must-use
Oct 24, 2026
Merged

CryptoJones merged 2 commits into
mainfrom
fix/clippy-double-must-use

Conversation

@CryptoJones

@CryptoJones CryptoJones commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Main's test job fails on current stable for two reasons that have nothing to do with recent changes:

  1. Clippy 1.99 flags tonic's generated code in scylla.engine.v1.rs (double_must_use). This adds that lint to the existing allow on the pb module, next to result_large_err.
  2. cargo audit fails on five new RustSec advisories in rustls 0.23.45 (RUSTSEC-2026-0346/0347/0348/0349) and rustls-webpki 0.103.15 (RUSTSEC-2026-0382). The fix is a lockfile-only update to 0.23.46 and 0.103.16.

Separately, http_gateway_token_gates_access failed once and passed on rerun. free_port() releases the port before the server binds it, so a parallel test's ungated server can take the port. That is a flaky test, not an auth bug, and this PR does not change it.

This unblocks #72 and any other PR.

Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/

🤖 Generated with Claude Code

https://claude.ai/code/session_01JMTyE9inRv7Knv6jkmgDZs

Clippy 1.99 flags tonic's generated client methods, which put #[must_use] on a
return type that is already #[must_use]. It is generated code, allowed next to
the existing result_large_err allow. This was failing the test job on every PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JMTyE9inRv7Knv6jkmgDZs
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 35 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 70dfcec1-e910-4ab9-8a13-639d721c5756
Commits

Reviewing files that changed from the base of the PR and between ba7eebb and 528df84.

Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 1
  • crates/scylla-engine/src/lib.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…sories

cargo audit fails the test job on RUSTSEC-2026-0346/0347/0348/0349 (rustls)
and RUSTSEC-2026-0382 (rustls-webpki). Both fixes are semver-compatible, so
this is a lockfile-only update.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JMTyE9inRv7Knv6jkmgDZs
@CryptoJones CryptoJones changed the title ci: allow clippy::double_must_use on the tonic-generated engine module ci: unblock the test job (clippy 1.99 lint, rustls advisories) Oct 24, 2026
@CryptoJones
CryptoJones merged commit 17001e6 into main Oct 24, 2026
3 checks passed
@CryptoJones
CryptoJones deleted the fix/clippy-double-must-use branch October 24, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant